[ADF v2]Add integration runtime sharing feature. by zhangyd2015 · Pull Request #3345 · Azure/azure-rest-api-specs

zhangyd2015 · 2018-07-03T07:32:01Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite
the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-07-03T07:33:26Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

zhangyd2015 · 2018-07-03T07:35:53Z

@annatisch This PR is the replacement with #3124, please review. The service has NOT been deployed to all the Prod regions, I will let you know when we are ready, so that you can help merge this pull request.

@hvermis please help review.

Thanks!

AutorestCI · 2018-07-03T07:36:40Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2770

AutorestCI · 2018-07-03T07:38:24Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-07-03T07:40:31Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

AutorestCI · 2018-07-03T07:42:15Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2008

hvermis · 2018-07-04T22:47:15Z

...resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/IntegrationRuntime.json

+      ]
+    },
+    "LinkedIntegrationRuntimeKey": {
+      "x-ms-discriminator-value": "Key",


Key [](start = 35, length = 3)

I think this name is not descriptive enough. It would help to see the generated .Net classes. Please generate the .Net SDK and and a CR.

Sure, I will do that

hvermis · 2018-07-04T22:48:49Z

In your other PR you also had listShared IRs and factories API-s, will you add them later?

hvermis · 2018-07-04T22:59:13Z

},

As discussed in the mail thread, you can delete this.

Refers to: specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/IntegrationRuntime.json:25 in 8252d05. [](commit_id = 8252d05, deletion_comment = False)

zhangyd2015 · 2018-07-05T02:34:34Z

@hvermis Yes I will add them later but not now, since the two API-s will be depending on the support from ARM implementation.

Sent you SDK CR with this swagger.

zhangyd2015 · 2018-07-05T02:46:02Z

For additionalProperties, I will prefer to do that in a separate pull request if the CI pass with this pull request.

annatisch · 2018-07-05T19:19:25Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+      "description": "Data factory name for linked integration runtime request.",
+      "type": "object",
+      "properties": {
+        "factoryName": {


@zhangyd2015
Would it be possible to add the extension "x-ms-client-name" here? Currently this name is the same as that used for the URL parameter factoryName. Readability could be improved by giving this property a different generated client name.
For an example of the current generated Python client:
https://github.com/Azure/azure-sdk-for-python/pull/2865/files#diff-fd2acb15b40ac1ce8749314b7e6619c0R1041

I think renaming will be better than using x-ms-client-name. Maybe linkedFactoryName?

Service code is pending deployment now and if we change the name we will need service code change and I don't want to block the deployment as we have been waiting for long time. On the other hand, the closure class name LinkedIntegrationRuntimeRequest has indicate its context.

I will prefer to add the extension x-ms-client-name here.

hvermis · 2018-07-05T20:19:36Z

...resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/IntegrationRuntime.json

+      "description": "The self-hosted integration runtime properties.",
+      "type": "object",
+      "properties": {
+        "linkedInfo": {


How about renaming linkedInfo to linkedIntegrationRuntimeAuthorization and the properties class to LinkedIntegrationRuntimeAuthorizationType, and the inherited classes to LinkedIntegrationRuntimeKeyAuthorization and LinkedIntegrationRuntimeRbacAuthorization

It is actually info here, not just authorization. we may add more properties here which are nothing related with authorization.

Agreed to change properties class to LinkedIntegrationRuntimeType, inherited classes to LinkedIntegrationRuntimeKeyAuthorization and LinkedIntegrationRuntimeRbacAuthorization

One more question here - Self Hosted IR can only have one linked IR? Shouldn't this be an array?

linked IR doesn't exist in self-hosted IR as property, it has its own entity with selfhosted IR info

hvermis

Please consider renaming some of properties and classes for better readability

zhangyd2015 · 2018-07-10T00:46:41Z

@annatisch Could you please merge this pull request if there is no other issue?

Add integration runtime sharing feature.

8252d05

azuresdkci assigned annatisch Jul 3, 2018

azuresdkci requested a review from annatisch July 3, 2018 07:32

AutorestCI mentioned this pull request Jul 3, 2018

[AutoPR datafactory/resource-manager] [ADF v2]Add integration runtime sharing feature. Azure/azure-sdk-for-python#2865

Merged

AutorestCI mentioned this pull request Jul 3, 2018

[AutoPR datafactory/resource-manager] [ADF v2]Add integration runtime sharing feature. Azure/azure-sdk-for-node#3108

Merged

AutorestCI mentioned this pull request Jul 3, 2018

[AutoPR datafactory/resource-manager] [ADF v2]Add integration runtime sharing feature. Azure/azure-sdk-for-java#2173

Merged

AutorestCI mentioned this pull request Jul 3, 2018

[AutoPR datafactory/resource-manager] [ADF v2]Add integration runtime sharing feature. Azure/azure-sdk-for-go#2167

Merged

hvermis reviewed Jul 4, 2018

View reviewed changes

annatisch reviewed Jul 5, 2018

View reviewed changes

hvermis reviewed Jul 5, 2018

View reviewed changes

hvermis approved these changes Jul 5, 2018

View reviewed changes

zhangyd2015 added 2 commits July 6, 2018 09:55

Add x-ms-client-name to LinkedIntegrationRuntimeRequest.factoryName

10967f6

Change class name according review comments

fce7b6f

hvermis approved these changes Jul 9, 2018

View reviewed changes

annatisch approved these changes Jul 10, 2018

View reviewed changes

annatisch merged commit f8d1e52 into Azure:master Jul 10, 2018

Conversation

zhangyd2015 commented Jul 3, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

zhangyd2015 commented Jul 3, 2018

Uh oh!

AutorestCI commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis commented Jul 4, 2018

Uh oh!

hvermis commented Jul 4, 2018

Uh oh!

zhangyd2015 commented Jul 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhangyd2015 commented Jul 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhangyd2015 Jul 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis left a comment

Choose a reason for hiding this comment

Uh oh!

zhangyd2015 commented Jul 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zhangyd2015 commented Jul 3, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jul 3, 2018 •

edited

Loading

AutorestCI commented Jul 3, 2018 •

edited

Loading

AutorestCI commented Jul 3, 2018 •

edited

Loading

AutorestCI commented Jul 3, 2018 •

edited

Loading

AutorestCI commented Jul 3, 2018 •

edited

Loading

zhangyd2015 commented Jul 5, 2018 •

edited

Loading

zhangyd2015 Jul 6, 2018 •

edited

Loading